chore: upgrade libp2p & related deps
#1471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
…de-libp2p-and-related
…de-libp2p-and-related
…re/upgrade-libp2p-and-related
|
Failing CI check to be solved by #1476 |
…0.0 (#1479) Bumps [eslint-plugin-functional](https://github.com/eslint-functional/eslint-plugin-functional) from 5.0.8 to 6.0.0. - [Release notes](https://github.com/eslint-functional/eslint-plugin-functional/releases) - [Changelog](https://github.com/eslint-functional/eslint-plugin-functional/blob/main/CHANGELOG.md) - [Commits](eslint-functional/eslint-plugin-functional@v5.0.8...v6.0.0) --- updated-dependencies: - dependency-name: eslint-plugin-functional dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
fryorcraken
approved these changes
Aug 16, 2023
| @@ -84,12 +84,10 @@ export function selectConnection( | |||
| let latestConnection: Connection | undefined; | |||
|
|
|||
| connections.forEach((connection) => { | |||
| if (connection.stat.status === "OPEN") { | |||
| if (connection.status === "open") { | |||
There was a problem hiding this comment.
Do they export an enum we could use here?
There was a problem hiding this comment.
ConnectionStatus is a type but no enum unfortunately
export type ConnectionStatus = 'open' | 'closing' | 'closed'
* use `peer:identify` instead of `peer:update` * dial the peer after initialising peer-exchange
Bumps [@libp2p/websockets](https://github.com/libp2p/js-libp2p) from 6.0.3 to 7.0.3. - [Release notes](https://github.com/libp2p/js-libp2p/releases) - [Changelog](https://github.com/libp2p/js-libp2p/blob/master/.release-please.json) - [Commits](libp2p/js-libp2p@peer-record-v6.0.3...websockets-v7.0.3) --- updated-dependencies: - dependency-name: "@libp2p/websockets" dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
already upgraded with 5ad0210 |
danisharora099
force-pushed
the
chore/upgrade-libp2p-and-related
branch
from
6ff8414
to
e8770c9
Compare
danisharora099
force-pushed
the
chore/upgrade-libp2p-and-related
branch
2 times, most recently
from
2fa9729
to
1fcd6ac
Compare
danisharora099
added a commit
that referenced
this pull request
Aug 16, 2023
This reverts commit bb6608e.
danisharora099
added a commit
that referenced
this pull request
Aug 16, 2023
* chore: update noise * update: package.lock * update: @chainsafe/libp2p-gossipsub * rm unwanted libp2p interface deps & bump up libp2p * refactor code for new deps * update: new package.lock * update package.lock * fix build * chore(deps)(deps-dev): bump eslint-plugin-functional from 5.0.8 to 6.0.0 (#1479) Bumps [eslint-plugin-functional](https://github.com/eslint-functional/eslint-plugin-functional) from 5.0.8 to 6.0.0. - [Release notes](https://github.com/eslint-functional/eslint-plugin-functional/releases) - [Changelog](https://github.com/eslint-functional/eslint-plugin-functional/blob/main/CHANGELOG.md) - [Commits](eslint-functional/eslint-plugin-functional@v5.0.8...v6.0.0) --- updated-dependencies: - dependency-name: eslint-plugin-functional dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(peer-exchange): refactor/fix compliance test (#1478) * use `peer:identify` instead of `peer:update` * dial the peer after initialising peer-exchange * re-enable @waku/tests (#1472) * chore(deps)(deps): bump @libp2p/websockets from 6.0.3 to 7.0.3 (#1481) Bumps [@libp2p/websockets](https://github.com/libp2p/js-libp2p) from 6.0.3 to 7.0.3. - [Release notes](https://github.com/libp2p/js-libp2p/releases) - [Changelog](https://github.com/libp2p/js-libp2p/blob/master/.release-please.json) - [Commits](libp2p/js-libp2p@peer-record-v6.0.3...websockets-v7.0.3) --- updated-dependencies: - dependency-name: "@libp2p/websockets" dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * import type for interface * update: tsdoc (#1476) * fix imports for merge * update typedoc exports * add: CustomEvent import * use new libp2p interface --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
|
how is this PR so massive? -45,000 lines??? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problems
New versions for deps like
were introduced which rely on a breaking change from libp2p to be upgraded to
0.46.3and improvements like deprecation of certain one-off interface packages are replaced with new exports.Solutions
This PR:
0.46.3)interfacepackages fromlibp2pand replaces them with new exportsNotes
Part of the maintenance milestone.
aegiras a dev dep ontestsbecause of bug: broken @libp2p/interface-compliance-tests libp2p/js-libp2p#1974if we use the former package it works (because it installed
aegiras a dependency instead of a dev) but we should move out to the new package because the former has not been updated in months/maintained anymore