Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: refactor store protocol for readability #1456

Merged
merged 9 commits into from
Aug 28, 2023

Conversation

danisharora099
Copy link
Collaborator

@danisharora099 danisharora099 commented Aug 7, 2023

Problem

This PR just refactors the Store protocol class to make it more readable.

Notes

  • is a general cleanup, and not part of any milestone

@github-actions
Copy link

github-actions bot commented Aug 7, 2023

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
Waku core 30.75 KB (0%) 616 ms (0%) 253 ms (-4.87% 🔽) 868 ms
Waku Simple Light Node 312.24 KB (+0.06% 🔺) 6.3 s (+0.06% 🔺) 798 ms (+47.89% 🔺) 7.1 s
ECIES encryption 28.68 KB (0%) 574 ms (0%) 262 ms (-10.23% 🔽) 835 ms
Symmetric encryption 28.69 KB (0%) 574 ms (0%) 238 ms (-24.83% 🔽) 812 ms
DNS discovery 116.43 KB (0%) 2.4 s (0%) 525 ms (+3.04% 🔺) 2.9 s
Privacy preserving protocols 123.18 KB (0%) 2.5 s (0%) 500 ms (+3.78% 🔺) 3 s
Light protocols 30.53 KB (0%) 611 ms (0%) 255 ms (-9.92% 🔽) 865 ms
History retrieval protocols 29.72 KB (+0.13% 🔺) 595 ms (+0.13% 🔺) 235 ms (-19.25% 🔽) 829 ms
Deterministic Message Hashing 5.78 KB (0%) 116 ms (0%) 73 ms (+58.31% 🔺) 189 ms

@danisharora099 danisharora099 marked this pull request as ready for review August 21, 2023 08:42
@danisharora099 danisharora099 requested a review from a team as a code owner August 21, 2023 08:42
@danisharora099 danisharora099 mentioned this pull request Aug 21, 2023
24 tasks
@fryorcraken
Copy link
Collaborator

This is a breaking change , title of PR shoul dbe changed to chore!:

@danisharora099 danisharora099 changed the title chore: refactor store protocol for readability chore!: refactor store protocol for readability Aug 22, 2023
@fryorcraken
Copy link
Collaborator

cc @LordGhostX for doc update

@danisharora099 danisharora099 merged commit 2389977 into master Aug 28, 2023
10 checks passed
@danisharora099 danisharora099 deleted the chore/readable-store branch August 28, 2023 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants