-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Refactors message decoding to abort as soon as a suitable decoder found #1414
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good - thanks for this!
apologies for the delay in review, the team was mostly away last few weeks
.
pls resolve conflicts and once the CI passes, we'll be happy to merge!
No problem at all! Merged and resolved conflicts! |
Thanks for the PR @balag3 - there were some type errors that were failing the build which I resolved in the above commits. (For context: there was nothing being returned from inside the map function, which led to the variable having the type of We can merge the PR once the checks pass. Thanks again. We appreciate the support. :) Cheers! |
Problem
See the description of the original issue: #1369
Solution
Use
Promise.any()
instead of tracking the successfully decoded message state (didDecodeMsg
)Notes
npm run fix
oknpm run check
oknpm run test
ok