Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Refactors message decoding to abort as soon as a suitable decoder found #1414

Merged
merged 6 commits into from
Jul 28, 2023

Conversation

balag3
Copy link
Contributor

@balag3 balag3 commented Jul 1, 2023

Problem

See the description of the original issue: #1369

Solution

Use Promise.any() instead of tracking the successfully decoded message state (didDecodeMsg)

Notes

npm run fix ok
npm run check ok
npm run test ok

@balag3 balag3 requested a review from fryorcraken as a code owner July 1, 2023 20:19
@balag3 balag3 changed the title Refactors message decoding to abort as soon as a suitable decoder found fix: Refactors message decoding to abort as soon as a suitable decoder found Jul 1, 2023
@fryorcraken fryorcraken requested review from a team and removed request for fryorcraken July 26, 2023 04:04
Copy link
Collaborator

@danisharora099 danisharora099 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good - thanks for this!

apologies for the delay in review, the team was mostly away last few weeks
.
pls resolve conflicts and once the CI passes, we'll be happy to merge!

packages/core/src/lib/filter/v1/index.ts Outdated Show resolved Hide resolved
@balag3
Copy link
Contributor Author

balag3 commented Jul 27, 2023

looks good - thanks for this!

apologies for the delay in review, the team was mostly away last few weeks . pls resolve conflicts and once the CI passes, we'll be happy to merge!

No problem at all! Merged and resolved conflicts!

@danisharora099
Copy link
Collaborator

danisharora099 commented Jul 27, 2023

Thanks for the PR @balag3 - there were some type errors that were failing the build which I resolved in the above commits.

(For context: there was nothing being returned from inside the map function, which led to the variable having the type of void)

We can merge the PR once the checks pass. Thanks again. We appreciate the support. :)

Cheers!

@danisharora099 danisharora099 merged commit 30fcace into waku-org:master Jul 28, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

improvement for decoding messages on filter
2 participants