Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use yamux instead of mplex #1771

Open
weboko opened this issue Jan 3, 2024 · 5 comments · May be fixed by #1894
Open

chore: use yamux instead of mplex #1771

weboko opened this issue Jan 3, 2024 · 5 comments · May be fixed by #1894
Assignees
@danisharora099
Labels
enhancement New feature or request

Comments

@weboko
Copy link
Collaborator

weboko commented Jan 3, 2024

This is a change request

Proposed Solutions

Use yamux here:

js-waku/packages/sdk/src/create.ts

Line 215 in c81872a

streamMuxers: [mplex()],

Notes

From the thread - waku-org/go-waku#851 (comment)
@weboko weboko added the enhancement New feature or request label Jan 3, 2024
@weboko weboko added this to Waku Jan 3, 2024
@weboko weboko mentioned this issue Jan 3, 2024
Closed
@chair28980 chair28980 moved this to Priority in Waku Jan 10, 2024
@danisharora099 danisharora099 linked a pull request Mar 7, 2024 that will close this issue
Draft
6 tasks
@danisharora099 danisharora099 moved this from Priority to In Progress in Waku Mar 7, 2024
@danisharora099 danisharora099 self-assigned this Mar 7, 2024
@danisharora099 danisharora099 moved this from In Progress to Blocked in Waku Mar 7, 2024
@danisharora099
Copy link
Collaborator

danisharora099 commented Mar 7, 2024 •
edited
Loading

Addressed in js-waku here: #1894

Blocked until nwaku releases support for yamux: waku-org/nwaku#2518

This was referenced Mar 7, 2024
Closed
Merged
@weboko
Copy link
Collaborator Author

weboko commented Apr 24, 2024

@danisharora099 seems to be unblocked by https://github.com/waku-org/nwaku/releases/tag/v0.27.0

@weboko weboko moved this from Blocked to To Do in Waku Apr 24, 2024
@danisharora099
Copy link
Collaborator

Yes, the PR upgraded nwaku to 0.27 but dials seem to be failing. Will come back to this and investigate

@danisharora099 danisharora099 moved this from To Do to In Progress in Waku Sep 18, 2024
@danisharora099
Copy link
Collaborator

Side update: #2139 (comment)

@danisharora099 danisharora099 moved this from In Progress to Blocked in Waku Oct 8, 2024
@danisharora099
Copy link
Collaborator

Blocked by libp2p/js-libp2p#2505 / ChainSafe/js-libp2p-yamux#91

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danisharora099 danisharora099

Labels
enhancement New feature or request
Projects
Waku
Status: Blocked
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: use yamux instead of mplex waku-org/js-waku
2 participants
@danisharora099 @weboko