add try catch

waku-org · Aug 17, 2023 · befbd37 · befbd37
1 parent 6a17cc3
commit befbd37
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 13 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/core/src/lib/light_push/index.ts b/packages/core/src/lib/light_push/index.ts
@@ -47,26 +47,35 @@ class LightPush extends BaseProtocol implements ILightPush {
     const { pubSubTopic = DefaultPubSubTopic } = this.options;
 
     const recipients: PeerId[] = [];
+    let query: PushRpc;
+
+    try {
+      if (!isSizeValid(message.payload)) {
+        log("Failed to send waku light push: message is bigger than 1MB");
+        return {
+          recipients,
+          errors: [SendError.SIZE_TOO_BIG]
+        };
+      }
 
-    if (!isSizeValid(message.payload)) {
-      log("Failed to send waku light push: message is bigger than 1MB");
-      return {
-        recipients,
-        errors: [SendError.SIZE_TOO_BIG]
-      };
-    }
+      const protoMessage = await encoder.toProtoObj(message);
+      if (!protoMessage) {
+        log("Failed to encode to protoMessage, aborting push");
+        return {
+          recipients,
+          errors: [SendError.ENCODE_FAILED]
+        };
+      }
 
-    const protoMessage = await encoder.toProtoObj(message);
-    if (!protoMessage) {
-      log("Failed to encode to protoMessage, aborting push");
+      query = PushRpc.createRequest(protoMessage, pubSubTopic);
+    } catch (error) {
+      log("Failed to encode to protoMessage", error);
       return {
         recipients,
         errors: [SendError.ENCODE_FAILED]
       };
     }
 
-    const query = PushRpc.createRequest(protoMessage, pubSubTopic);
-
     const peers = await this.getPeers(3, true, opts?.peerId && [opts?.peerId]);
 
     const promises = peers.map(async (peer) => {