fix(otel): order of using TraceMiddlewareInnerGRpc

waitingsong · Oct 29, 2024 · 3e56a14 · 3e56a14
1 parent a92309e
commit 3e56a14
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/packages/otel/src/configuration.ts b/packages/otel/src/configuration.ts
@@ -93,12 +93,12 @@ export class AutoConfiguration implements ILifeCycle {
 
     if (this.config.enable) {
       registerMiddleware(this.app, TraceMiddlewareInner, 'last')
-      // registerMiddleware(this.grpcApp as unknown as Application, TraceMiddlewareInnerGRpc, 'last')
 
       const grpcFramework = this.frameworkService.getFramework('gRPC')
       // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
       if (grpcFramework) {
-        registerMiddleware(grpcFramework.getApplication() as unknown as Application, TraceMiddlewareInnerGRpc, 'first')
+        const rpcApp = grpcFramework.getApplication() as unknown as Application
+        registerMiddleware(rpcApp, TraceMiddlewareInnerGRpc, 'last')
       }
     }
   }

diff --git a/packages/otel/src/imports.ts b/packages/otel/src/imports.ts
@@ -1,4 +1,4 @@
-import * as grpc from '@midwayjs/grpc'
+// import * as grpc from '@midwayjs/grpc'
 import * as info from '@midwayjs/info'
 import * as koa from '@midwayjs/koa'
 import * as swagger from '@midwayjs/swagger'
@@ -17,7 +17,7 @@ if (CI) {
   useComponents.push(koa)
   useComponents.push(info)
   useComponents.push(swagger)
-  useComponents.push(grpc)
+  // useComponents.push(grpc)
 }
 
 useComponents.push(share)