Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Vue-TS Template #3234

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Fix Vue-TS Template #3234

merged 1 commit into from
Feb 5, 2024

Conversation

atterpac
Copy link
Member

@atterpac atterpac commented Feb 4, 2024

Description

An old version of vue-ts in the package.json depencies would break the build command updating to latest ^1.8.27 fixes this build step.

Fixes # (issue)
#3233

Type of change

  • [ X ] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • [ X ] Linux

Test Configuration

Version         | v2.7.1
Package Manager | apt

System
┌───────────────────────────────────────────────────────────┐
| OS           | Ubuntu                                     |
| Version      | 22.04                                      |
| ID           | ubuntu                                     |
| Go Version   | go1.21.1                                   |
| Platform     | linux                                      |
| Architecture | amd64                                      |
| CPU          | 12th Gen Intel(R) Core(TM) i5-1235U        |
| GPU          | unknown (Intel Corporation) - Driver: i915 |
| Memory       | 7GB                                        |
└───────────────────────────────────────────────────────────┘
Dependencies
┌──────────────────────────────────────────────────────────────────────────┐
| Dependency | Package Name          | Status    | Version                 |
| *docker    | docker.io             | Installed | 24.0.6                  |
| gcc        | build-essential       | Installed | 12.9ubuntu3             |
| libgtk-3   | libgtk-3-dev          | Installed | 3.24.33-1ubuntu2        |
| libwebkit  | libwebkit2gtk-4.0-dev | Installed | 2.42.4-0ubuntu0.22.04.1 |
| npm        | npm                   | Installed | 9.8.1                   |
| *nsis      | nsis                  | Installed | v3.08-2                 |
| pkg-config | pkg-config            | Installed | 0.29.2-1ubuntu3         |
└──────────────────────── * - Optional Dependency ─────────────────────────┘```


<!-- This is an auto-generated comment: release notes by coderabbit.ai -->

## Summary by CodeRabbit

- **Bug Fixes**
	- Fixed build error in vue-ts template.

- **Improvements**
	- Improved build stability and error handling.

- **Documentation**
	- Enhanced documentation for specific features.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

Copy link
Contributor

coderabbitai bot commented Feb 4, 2024

Walkthrough

This update brings a notable improvement to the project's development environment, particularly for those using the vue-ts template. Thanks to @atterpac's contribution, a build error has been resolved, enhancing the overall build stability and error handling in the process. Additionally, the documentation has received targeted enhancements, making specific features clearer and more accessible to developers.

Changes

Files Changes
.../vue-ts template Fixed build error
Build & error handling systems Improved stability and error handling
Documentation Enhanced for specific features

"In the code's garden, under the moon's soft gaze,
A fix was planted, through the error's maze.
🌟 Stability blooms, docs grow wide and tall,
A rabbit's cheer, for progress made for all."
🐰✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

changelog
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 9b35616 and e45059a.
Files ignored due to path filters (1)
  • v2/pkg/templates/templates/vue-ts/frontend/package.json is excluded by: !**/*.json
Files selected for processing (1)
  • website/src/pages/changelog.mdx (1 hunks)
Additional comments: 1
website/src/pages/changelog.mdx (1)
  • 27-28: The addition of the vue-ts template build error fix is correctly formatted and logically placed under the "Fixed" section for the upcoming release. The use of a bullet point and the inclusion of the PR link follows the established format of the changelog.

@leaanthony leaanthony merged commit 9903ba7 into wailsapp:master Feb 5, 2024
10 checks passed
@leaanthony
Copy link
Member

Thanks @atterpac 🙏🙏🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants