-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Give explicit example of importing JS runtime #3178
Conversation
No where in the docs, google, github issues or discussions could I find an example of importing the runtime JS but after some experimentation I figured it out. I think it would help future users if a simple example was shown like this so they have a clear reference of how to import the runtime.
Summary of changeswebsite/versioned_docs/version-v2.7.0/reference/runtime/intro.mdx: The change introduces an example of importing the The change introduces documentation on explicitly importing the JS runtime. This addition was made by @danawoodman in PR. WalkthroughThe recent update introduces documentation for explicitly importing the JS runtime and provides an example of importing the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- website/versioned_docs/version-v2.7.0/reference/runtime/intro.mdx (1 hunks)
Additional comments: 1
website/versioned_docs/version-v2.7.0/reference/runtime/intro.mdx (1)
- 37-42: The example provided for importing the
EventsOn
function in a Svelte application is clear and concise. It's good to see TypeScript being used, as it can help with type safety and autocompletion in supported IDEs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- website/versioned_docs/version-v2.7.0/reference/runtime/intro.mdx (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- website/versioned_docs/version-v2.7.0/reference/runtime/intro.mdx
Thanks for this🙏 Please could you add an entry to the changelog located at |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- website/src/pages/changelog.mdx (1 hunks)
Files skipped from review due to trivial changes (1)
- website/src/pages/changelog.mdx
done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- website/src/pages/changelog.mdx (1 hunks)
Additional comments: 1
website/src/pages/changelog.mdx (1)
- 23-23: The changelog entry for the documentation addition is correctly formatted and follows the established pattern of previous entries.
Thanks for this @danawoodman 🙏 |
Description
No where in the docs, google, github issues or discussions could I find an example of importing the runtime JS but after some experimentation I figured it out.
I think it would help future users if a simple example was shown like this so they have a clear reference of how to import the runtime.
Type of change
docs
How Has This Been Tested?
n/a
Test Configuration
n/a
Checklist:
n/a
Summary by CodeRabbit
EventsOn
function in a Svelte application with TypeScript support.