Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing runtime.UnlockOSThread() #2994

Merged
merged 2 commits into from
Oct 21, 2023

Conversation

seleborg
Copy link
Contributor

Description

I think there might have been a missing call to defer runtime.UnlockOSThread(). I haven't observed any actual bug from this, this is merely from reading the code.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

I haven't. Please review if this seems reasonable to you. Best to discard if there are any doubts.

Test Configuration

OS | Windows 10 Enterprise
Version | 2009 (Build: 22621)
ID | 22H2
Go Version | go1.18.10
Platform | windows
Architecture | amd64

Version | v2.5.1

Dependency | Package Name | Status | Version
WebView2 | N/A | Installed | 118.0.2088.46
Nodejs | N/A | Installed | 18.17.1
npm | N/A | Installed | 9.6.7
*upx | N/A | Available |
*nsis | N/A | Available |

    • Optional Dependency

Your system is ready for Wails development!
Optional package(s) installation details:

Checklist:

  • I have updated website/src/pages/changelog.mdx with details of this PR
  • My code follows the general coding style of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@leaanthony leaanthony merged commit b5406cb into wailsapp:master Oct 21, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants