Add missing runtime.UnlockOSThread() #2994
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I think there might have been a missing call to
defer runtime.UnlockOSThread()
. I haven't observed any actual bug from this, this is merely from reading the code.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
I haven't. Please review if this seems reasonable to you. Best to discard if there are any doubts.
Test Configuration
OS | Windows 10 Enterprise
Version | 2009 (Build: 22621)
ID | 22H2
Go Version | go1.18.10
Platform | windows
Architecture | amd64
Version | v2.5.1
Dependency | Package Name | Status | Version
WebView2 | N/A | Installed | 118.0.2088.46
Nodejs | N/A | Installed | 18.17.1
npm | N/A | Installed | 9.6.7
*upx | N/A | Available |
*nsis | N/A | Available |
Your system is ready for Wails development!
Optional package(s) installation details:
Checklist:
website/src/pages/changelog.mdx
with details of this PR