[v3] Fix service name determination (#3827)

Should use service instance, not Service wrapper struct.
wailsapp · Oct 31, 2024 · e4cfae2 · e4cfae2
1 parent bd0c366
commit e4cfae2
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/mkdocs-website/docs/en/changelog.md b/mkdocs-website/docs/en/changelog.md
@@ -26,6 +26,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Taskfile refactor by [leaanthony](https://github.com/leaanthony) in [#3748](https://github.com/wailsapp/wails/pull/3748)
 - Upgrade to `go-webview2` v1.0.16 by [leaanthony](https://github.com/leaanthony)
 - Fixed `Screen` type to include `ID` not `Id` by [etesam913](https://github.com/etesam913) in [#3778](https://github.com/wailsapp/wails/pull/3778)
+- Fixed service name determination by [windom](https://github.com/windom/) in [#3827](https://github.com/wailsapp/wails/pull/3827)
 - mkdocs serve now uses docker by [leaanthony](https://github.com/leaanthony)
 
 ### Fixed

diff --git a/v3/pkg/application/application.go b/v3/pkg/application/application.go
@@ -142,7 +142,7 @@ func New(appOptions Options) *App {
 			if err != nil {
 				name := service.options.Name
 				if name == "" {
-					name = getServiceName(service)
+					name = getServiceName(service.instance)
 				}
 				globalApplication.Logger.Error("OnStartup() failed:", "service", name, "error", err.Error())
 				continue