Release #323
Merged
Release #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* startMinute, endMinute null인 경우만 싱크 * startMinute, endMinute null인 경우만 싱크2
Hank-Choi
requested review from
davin111,
Jhvictor4 and
subeenpark-io
and removed request for
a team
Hank-Choi
commented
Aug 7, 2023
| const startTime = Time.fromHourMinuteString(it.start_time) | ||
| const endTime = Time.fromHourMinuteString(it.end_time) | ||
| it.startMinute = startTime.totalMinute | ||
| it.endMinute = endTime.totalMinute | ||
| } else if (it.start && it.len) { |
There was a problem hiding this comment.
start,len이 있어서
isInvalidClassTime 씹고 들어왔는데
start나 len이 0이면
여기 안 걸려서 startMinute, endMinute 설정 안됐음
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.