Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release #313

Merged
merged 2 commits into from
Aug 2, 2023
Merged

Release #313

merged 2 commits into from
Aug 2, 2023

Conversation

davin111
Copy link
Member

@davin111 davin111 commented Aug 2, 2023

No description provided.

dependabot bot and others added 2 commits July 24, 2023 09:06
Bumps [semver](https://github.com/npm/node-semver) from 5.5.0 to 5.7.2.
- [Release notes](https://github.com/npm/node-semver/releases)
- [Changelog](https://github.com/npm/node-semver/blob/v5.7.2/CHANGELOG.md)
- [Commits](npm/node-semver@v5.5.0...v5.7.2)

---
updated-dependencies:
- dependency-name: semver
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@davin111 davin111 self-assigned this Aug 2, 2023
@davin111 davin111 requested a review from a team as a code owner August 2, 2023 00:40
@davin111 davin111 requested review from Hank-Choi, Jhvictor4 and subeenpark-io and removed request for a team August 2, 2023 00:40
Copy link
Contributor

@Jhvictor4 Jhvictor4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

필드가 없으면 안 건드려야 하는 것 아닌가.. 엄
몽고가 덮어쓸줄은 몰랐다
대처 감사!!

@davin111
Copy link
Member Author

davin111 commented Aug 2, 2023

@Jhvictor4 나도 이게 prod 에 nickname 없는 유저 생겨있는 직접적인 원인이었는지 좀 헷갈려. prod 에서 snutt-core 에서 users update 실행되는 api 호출해보니까 nickname 이 그대로 유지되는 경우도 있었어서. 일단 이건 암튼 일관성 차원에서도 반영되면 좋으니까 merge 하고, 계속 지켜보는 것은 필요할 듯.

@davin111 davin111 merged commit f365512 into master Aug 2, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants