Rewrite SyllabusWebView #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peng-u-0807
approved these changes
Oct 21, 2024
Comment on lines
29
to
31
| progressBar.layer.shadowColor = UIColor.blue.cgColor | ||
| progressBar.layer.shadowRadius = 10.0 | ||
| progressBar.layer.shadowOpacity = 0.9 |
There was a problem hiding this comment.
그라데이션까지 넣으니까 좀 튀어서 그림자는 뺄까 싶은데 어때
Suggested change
| progressBar.layer.shadowColor = UIColor.blue.cgColor | |
| progressBar.layer.shadowRadius = 10.0 | |
| progressBar.layer.shadowOpacity = 0.9 | |
| progressBar.layer.shadowColor = UIColor.blue.withAlphaComponent(0.5).cgColor |
Progress.Bar.mov
There was a problem hiding this comment.
progressBar.layer.shadowColor = UIColor.blue.withAlphaComponent(0.5).cgColor 이건 뭐야? 이것도 없애자는거 맞지?
아닌가 그림자를 아예 빼자는 소리는 아닌가
There was a problem hiding this comment.
앗 깃헙 코멘트 알림이 왜 안떴지...그림자 아예 빼자는거였는데 suggestion 잘못 입력한듯
| func makeUIViewController(context _: UIViewControllerRepresentableContext<Self>) -> UIViewController { | ||
| let webViewController = SyllabusWebViewController(entryURL: URL(string: urlString)) | ||
| let navigationController = UINavigationController(rootViewController: webViewController) | ||
| var appearance = UINavigationBarAppearance() |
There was a problem hiding this comment.
사소하긴 한데 여기 let으로 바꾸라고 warning 뜨네
chaemin2001
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ScreenRecording_10-19-2024.21-55-45_1.MP4