Add NoticeView
#313
Merged
Add NoticeView
#313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shp7724
approved these changes
Sep 29, 2024
peng-u-0807
force-pushed
the
peng-u-0807/add-notice-view
branch
from
6ac0a5f
to
0106fa8
Compare
peng-u-0807
added a commit
that referenced
this pull request
Sep 29, 2024
* Add `NoticeView` * Apply SwiftFormat changes * `notices` -> `notice` --------- Co-authored-by: peng-u-0807 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
수정사항
NoticeView를 위해 config 불러올 Service가 마땅치 않아서 가장 맥락 맞아보이는GlobalUIService쪽에다 붙였습니다