Fix Toolbar spacing #311
Merged
Fix Toolbar spacing #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
peng-u-0807
commented
Sep 4, 2024
peng-u-0807
commented
- 친구 기기에서 TimetableScene toolbar overflow를 발견했는데 toolbar로는 해결이 어려워서 HStack으로 변경
- 관련 이미지
shp7724
reviewed
Sep 6, 2024
| @@ -13,6 +13,7 @@ struct TimetableScene: View, Sendable { | |||
| @State private var pushToListScene = false | |||
| @State private var isShareSheetOpened = false | |||
| @State private var screenshot: UIImage = .init() | |||
| @State private var screenSize: CGSize = .zero | |||
There was a problem hiding this comment.
시간표 이미지를 full-screen 사이즈로 만들게 아니라서 변수를 따로 둬야하긴해
There was a problem hiding this comment.
그건 아는데 geometry reader의 위치를 바꾸든지 해서 직접 읽어오게 하면 좋을듯
There was a problem hiding this comment.
customToolBar height를 그냥 상수로 두게 바꿨어 커밋올림~!
shp7724
approved these changes
Sep 8, 2024
peng-u-0807
added a commit
that referenced
this pull request
Sep 19, 2024
* Fix Toolbar spacing * Apply SwiftFormat changes * Remove `screenSize` * Apply SwiftFormat changes --------- Co-authored-by: peng-u-0807 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.