Fix default value for empty notification title #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shp7724
reviewed
Jan 20, 2024
| @@ -8,7 +8,7 @@ | |||
| import Foundation | |||
|
|
|||
| struct NotificationDto: Decodable { | |||
| let title: String | |||
| var title: String | |||
There was a problem hiding this comment.
@shp7724 아래에서 if title.isEmpty 구문때문에 let으로 바꾸면 아마 에러뜰거에요 저도 그래서 var로 했던듯?
There was a problem hiding this comment.
클로져나 함수로 빼면 한번만 initialize 해도 될것같아여
shp7724
approved these changes
Jan 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
수정사항
title값이 비어있는 예전의 알림들에 대해서는 default title값을 사용하도록 수정했습니다