Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile is not exclusive, removing additional profiles #20

Merged
merged 1 commit into from
Jul 30, 2020

Conversation

mlagally
Copy link
Contributor

@mlagally mlagally commented Jul 30, 2020

Removing text for Digital Twin and Thing Templates for Spec version 1.0.
Adding text to clarify that the profile is not exclusive.

This MR addresses and resolves:
#9
#18
#8


Preview | Diff

…nd Thing Templates for Spec version 1.0

This MR addresses and resolves:
#9
#18
#8
</ul>
<p>Profiles are is not exclusive, they can overlap or
include others.
<p>Note that the core profile is not exclusive. Device implementers are free to adopt
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for this. However, I'm still struggling with the term "core" or "core profile" since this infer that the core have to be always there whatever you are doing. This would be not the case if a Thing is only able to support CoAP as example.

I'm thinking about the term "default". This implies that there are some default assumptions and if those are not other specified the default assumption will be followed. I will setup a separate issue about this point.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also see #21

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder whether it makes sense to make a technical statement such as calling it according to the technology used e.g,. "http-json" profile (as far as I understand the recent discussion that's what it will be now, see #9 (comment). Correct? Different to the phase the profile work started were the idea was to setup means to define a profile).

Using actual names like "http-json" make the idea of a given profile very easy to grasp. Generic terms like "core" or "default" are very fuzzy with that regard.

@mlagally
Copy link
Contributor Author

The naming question needs to be revisited once we have defined the content of the profile spec.

@mlagally mlagally merged commit e7e9ecd into master Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants