Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin definitions when building an older version #4155

Merged
merged 1 commit into from
Nov 28, 2024
Merged

Conversation

kfranqueiro
Copy link
Contributor

This is a follow-up to #4007, in which I had neglected to pin definitions for key terms to the published recommendation when building for 2.1.

  • Moves termsMap definition to the Eleventy config (where all other target-version-dependent assignments are made), to be passed into the CustomLiquid constructor
  • Updates termsMap references within CustomLiquid to use an instance variable set in the constructor
  • Updates loadRemoteGuidelines to account for pre-processed terms content
  • Skips entirety of custom render processing for pages not being output for 2.1 (to avoid irrelevant error messages as well as save time)

@w3cbot
Copy link

w3cbot commented Nov 27, 2024

kfranqueiro marked as non substantive for IPR from ash-nazg.

Copy link

netlify bot commented Nov 27, 2024

Deploy Preview for wcag2 ready!

Name Link
🔨 Latest commit f5bd845
🔍 Latest deploy log https://app.netlify.com/sites/wcag2/deploys/67479ace265e250008d682a3
😎 Deploy Preview https://deploy-preview-4155--wcag2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@iadawn iadawn merged commit 7aad7a7 into main Nov 28, 2024
5 checks passed
@kfranqueiro kfranqueiro deleted the kgf-pin-definitions branch December 2, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants