Rewrite iframe source attributes in APG #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A forthcoming change to APG will add a relative-source `<iframe>` element to the APG's "Feed" example page [1]. Update the build script to transform this value using the mechanism established for other types of resources. [1] w3c/aria-practices#2775
✅ Deploy Preview for aria-practices ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
6 tasks
howard-e
approved these changes
Oct 2, 2023
|
Thanks, @howard-e! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A forthcoming change to APG will add a relative-source
<iframe>element to the APG's "Feed" example page [1]. Update the build script to transform this value using the mechanism established for other types of resources.[1] w3c/aria-practices#2775
I'm not confident that this change is valid because I haven't been able to find tests for the logic I modified. I've experimentally verified that it appears to function as intended without undesirable side effects by making some local modifications to the APG source and inspecting the result.
At the moment, it appears that all of the
<iframe>elements in APG use absolute URLs for theirsrcattributes and thus not effected by the transformation.$ find _external/aria-practices/ -type f -iname '*.html' -print0 | xargs -0 grep -i '<iframe' -A2