Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve alt text for most images #18

Merged

Conversation

TallTed
Copy link
Member

@TallTed TallTed commented Oct 24, 2024

@TallTed TallTed requested a review from iherman as a code owner October 24, 2024 19:18
Copy link
Member

@iherman iherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @TallTed.

Actually, figures 2, 3, 4, 5, 7, 9, and 10 come from their respective specs (VCDM, DI, Bitstring), including their alt text. I think we should "retrofit" these new alt texts to their original place, too. @msporny, if you think that is appropriate, I am happy to raise PRs doing just that.

@iherman
Copy link
Member

iherman commented Oct 25, 2024

@TallTed, if you think you are done with this one, I presume it is all right to merge this without waiting a full week...

@iherman iherman merged commit 2463b8a into alt-text-improvements Oct 29, 2024
1 check failed
@TallTed TallTed deleted the TallTed-20241024-alt-text-improvements branch October 29, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants