Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests to use triple term <<(·)>> syntax instead of reified triple syntax <<·>>. #165

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kasei
Copy link
Contributor

@kasei kasei commented Jan 26, 2025

Some tests seemed to be using the old CG syntax, but I believe the current state of specs means that the reified triple syntax tokens << and >> should never appear in n-quads data. This PR replaces them with the triple term tokens <<( and )>>.

@kasei kasei requested a review from gkellogg January 26, 2025 17:57
@afs
Copy link
Contributor

afs commented Jan 26, 2025

Yes, they are old CG syntax.

They shouldn't have triple terms as subjects for RDF 1.2.

I think NQ is lagging NT due to "too many things to do".

@kasei
Copy link
Contributor Author

kasei commented Jan 26, 2025

Yeah, that's what I figured. Going through them and making some fixes as I go.

@gkellogg
Copy link
Member

I think more updates were made to N-Triples Triple Terms. All N-Triples tests should be duplicated as N-Quads tests, and it probably needs N-Quads specific tests (although, that may be covered here).

Copy link
Member

@gkellogg gkellogg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just changing old syntax to Triple Terms doesn't account for restrictions on where they can be made; a number of these should be negative tests now

@@ -1 +1 @@
<< <http://example/s> <http://example/p> <http://example/o> >> <http://example/q> <http://example/z> <http://example/g> .
<<( <http://example/s> <http://example/p> <http://example/o> )>> <http://example/q> <http://example/z> <http://example/g> .
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Manifest needs to be updated for this to be a Negative Syntax Test.

@@ -1 +1 @@
<< <http://example/s1> <http://example/p1> <http://example/o1> >> <http://example/q> << <http://example/s2> <http://example/p2> <http://example/o2> >> <http://example/g> .
<<( <http://example/s1> <http://example/p1> <http://example/o1> )>> <http://example/q> <<( <http://example/s2> <http://example/p2> <http://example/o2> )>> <http://example/g> .
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Manifest needs to be updated for this to be a Negative Syntax Test.

@@ -1 +1 @@
<<<http://example/s1><http://example/p1><http://example/o1>>><http://example/q><<<http://example/s2><http://example/p2><http://example/o2>>><http://example/g>.
<<(<http://example/s1><http://example/p1><http://example/o1>)>><http://example/q><<(<http://example/s2><http://example/p2><http://example/o2>)>><http://example/g>.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Manifest needs to be updated for this to be a Negative Syntax Test.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, good catch. I just did a search and replace, and hadn't pulled back far enough to recognize the issue that introduced in these tests.

<<(<<(<http://example/s1><http://example/p1><http://example/o1>)>><http://example/q1><<(<http://example/s2><http://example/p2><http://example/o2>)>>)>><http://example/q2><<(<<(<http://example/s3><http://example/p3><http://example/o3>)>><http://example/q3><<(<http://example/s4><http://example/p4><http://example/o4>)>>)>><http://example/g>.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Manifest needs to be updated for this to be a Negative Syntax Test.

@gkellogg gkellogg changed the title Update tests to use triple term <<(·)>> syntax instead of reified triplel syntax <<·>>. Update tests to use triple term <<(·)>> syntax instead of reified triple syntax <<·>>. Jan 26, 2025
@rubensworks
Copy link
Member

The TriG test suite will require similar changes (#161).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants