Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update note about datasets and SPARQL #133

Merged
merged 2 commits into from
Jan 22, 2025
Merged

Update note about datasets and SPARQL #133

merged 2 commits into from
Jan 22, 2025

Conversation

afs
Copy link
Contributor

@afs afs commented Jan 16, 2025

spec/index.html Outdated Show resolved Hide resolved
spec/index.html Outdated Show resolved Hide resolved
spec/index.html Outdated Show resolved Hide resolved
@afs afs requested review from gkellogg and hartig January 17, 2025 09:44
@afs afs added the spec:editorial Minor change in the specification (markup, typo, informative text; class 1 or 2) label Jan 20, 2025
@afs afs merged commit 23dfb05 into main Jan 22, 2025
2 checks passed
@afs afs deleted the sparql-dataset branch January 22, 2025 15:18
Copy link
Member

@TallTed TallTed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know if you need a PR from me with these tweaks.

Comment on lines +1016 to +1017
<a data-cite="SPARQL12-QUERY#sparqlDataset">the same concept of an RDF Dataset</a>
in which the graph names of named graphs may be IRIs or blank nodes.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SPARQL 1.2 [[SPARQL12-QUERY]] uses
<a data-cite="SPARQL12-QUERY#sparqlDataset">the same concept of an RDF Dataset</a>
as ... what/where/when? ...,
in which the graph names of named graphs may be IRIs or blank nodes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"RDF Dataset" is defined immediately above the note so I think it is clear.

Comment on lines +1018 to +1019
In contrast, version 1.1 of the SPARQL Query Language [[SPARQL11-QUERY]]
only allows IRIs as graph names.</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
In contrast, version 1.1 of the SPARQL Query Language [[SPARQL11-QUERY]]
only allows IRIs as graph names.</p>
In contrast, version 1.1 of the SPARQL Query Language [[SPARQL11-QUERY]]
only allows IRIs (not blank nodes) to be the graph names of named graphs.</p>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"RDF Dataset" is defined immediately above the note.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec:editorial Minor change in the specification (markup, typo, informative text; class 1 or 2)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants