Stop fetching spec info from Specref #1668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This completely drops the logic that used to fetch spec info from Specref. Motivation for the change is to avoid having a circular dependency between browser-specs and Specref that makes it cumbersome to make some updates. In practice, there remained only 6 specs for which browser-specs was leveraging Specref: 3 from ISO, 2 from TC39 and the Web Bluetooth API. One consequence is that the title of the TC39 specs will change because the actual specs include a registered mark and the year, which are now captured, leading to "ECMAScript® 2025 Language Specification". Maybe not ideal, but then that's per spec... README and comments updated in the code to remove mentions of Specref.
|
Note: CI tests fail because there remain specs in |
|
hmm... I'm a bit confused - how are going to fetch info for ISO specs moving forward? |
From the ISO pages. We already have that logic in place and we just have 3 ISO specs in the list for now. |
dontcallmedom
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This completely drops the logic that used to fetch spec info from Specref. Motivation for the change is to avoid having a circular dependency between browser-specs and Specref that makes it cumbersome to make some updates.
In practice, there remained only 6 specs for which browser-specs was leveraging Specref: 3 from ISO, 2 from TC39 and the Web Bluetooth API.
One consequence is that the title of the TC39 specs will change because the actual specs include a registered mark and the year, which are now captured, leading to "ECMAScript® 2025 Language Specification". Maybe not ideal, but then that's per spec...
README and comments updated in the code to remove mentions of Specref.