-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken links and update publication metadata #2102
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly questions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just one question
index.html
Outdated
"FPWD": "https://w3c.github.io/aria/", | ||
"WD": "https://w3c.github.io/aria/", | ||
"CR": "https://w3c.github.io/aria/", | ||
"REC": "https://w3c.github.io/aria/", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be all pointing to the editor's draft? shouldn't they mostly be pointing to 1.3 first public working draft?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But if we point to that now they probably won't work. I think we need to wait until FPWD is published on TR space and then update them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I basically meant to ask the same question but did so on the other side of the diff.
@spectranaut @pkra I think I've addressed most of your comments. ARE you happy for me to merge this? |
This reverts commit a84b9a5.
Daniel, I still have one question, all the URLS in the For example, the "searchbox" link in this section of the preview: https://pr-preview.s3.amazonaws.com/w3c/aria/pull/2102.html#introroles All the links that are not relative links go back to the editor's draft. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please @pkra and @spectranaut see my comments. They have been pending all these days because I marked them as "review" comments instead of "single comments".
I changed the links that were pointing to the editor's draft.
The practices lihnk I think it's OK. Otherwise I am not really understanding what @pkra 's concern is with it.
index.html
Outdated
"FPWD": "https://w3c.github.io/aria/", | ||
"WD": "https://w3c.github.io/aria/", | ||
"CR": "https://w3c.github.io/aria/", | ||
"REC": "https://w3c.github.io/aria/", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But if we point to that now they probably won't work. I think we need to wait until FPWD is published on TR space and then update them.
That's now changed. |
Preview | Diff