Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken links and update publication metadata #2102

Merged
merged 5 commits into from
Jan 16, 2024

Conversation

daniel-montalvo
Copy link
Contributor

@daniel-montalvo daniel-montalvo commented Jan 9, 2024

Copy link
Member

@pkra pkra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly questions.

index.html Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Show resolved Hide resolved
Copy link
Contributor

@spectranaut spectranaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one question

index.html Outdated
"FPWD": "https://w3c.github.io/aria/",
"WD": "https://w3c.github.io/aria/",
"CR": "https://w3c.github.io/aria/",
"REC": "https://w3c.github.io/aria/",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be all pointing to the editor's draft? shouldn't they mostly be pointing to 1.3 first public working draft?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But if we point to that now they probably won't work. I think we need to wait until FPWD is published on TR space and then update them.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I basically meant to ask the same question but did so on the other side of the diff.

@daniel-montalvo
Copy link
Contributor Author

@spectranaut @pkra I think I've addressed most of your comments. ARE you happy for me to merge this?

@spectranaut
Copy link
Contributor

spectranaut commented Jan 11, 2024

@spectranaut @pkra I think I've addressed most of your comments. ARE you happy for me to merge this?

Daniel, I still have one question, all the URLS in the ariaSpecURLs object point to the editors draft at github.io -- so a lot of the links within the preview go to the editors draft. I thought they should point back to the FFWD?

For example, the "searchbox" link in this section of the preview: https://pr-preview.s3.amazonaws.com/w3c/aria/pull/2102.html#introroles

All the links that are not relative links go back to the editor's draft.

@daniel-montalvo daniel-montalvo changed the title Fix broken links and updates publication metadata Fix broken links and update publication metadata Jan 15, 2024
Copy link
Contributor Author

@daniel-montalvo daniel-montalvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please @pkra and @spectranaut see my comments. They have been pending all these days because I marked them as "review" comments instead of "single comments".

I changed the links that were pointing to the editor's draft.

The practices lihnk I think it's OK. Otherwise I am not really understanding what @pkra 's concern is with it.

index.html Show resolved Hide resolved
index.html Outdated
"FPWD": "https://w3c.github.io/aria/",
"WD": "https://w3c.github.io/aria/",
"CR": "https://w3c.github.io/aria/",
"REC": "https://w3c.github.io/aria/",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But if we point to that now they probably won't work. I think we need to wait until FPWD is published on TR space and then update them.

index.html Show resolved Hide resolved
@daniel-montalvo
Copy link
Contributor Author

@spectranaut @pkra I think I've addressed most of your comments. ARE you happy for me to merge this?

Daniel, I still have one question, all the URLS in the ariaSpecURLs object point to the editors draft at github.io -- so a lot of the links within the preview go to the editors draft. I thought they should point back to the FFWD?

For example, the "searchbox" link in this section of the preview: https://pr-preview.s3.amazonaws.com/w3c/aria/pull/2102.html#introroles

All the links that are not relative links go back to the editor's draft.

That's now changed.

@daniel-montalvo daniel-montalvo merged commit a8c0ef5 into FPWD-WAI-ARIA-1.3 Jan 16, 2024
5 checks passed
@pkra pkra mentioned this pull request Feb 2, 2024
pkra pushed a commit that referenced this pull request Feb 7, 2024
github-actions bot added a commit that referenced this pull request Feb 7, 2024
SHA: c891215
Reason: push, by pkra

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants