Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Separate kbd cords for multiple key strokes #1611

Closed
wants to merge 1 commit into from

Conversation

nschonni
Copy link
Contributor

@nschonni nschonni commented Nov 11, 2020

Related to this, it would be nice to have a little styling on the kbd element, but I'm not sure if that's something that is supposed to come from the common CSS rather than specific to this repo. Some examples of the styling over here https://auth0.github.io/kbd/


Preview | Diff

@github-actions
Copy link
Contributor

Regression test coverage:

Examples without any regression tests:

  • dialog-modal/alertdialog.html

Examples missing some regression tests:

  • dialog-modal/datepicker-dialog.html:
    • textbox-aria-describedby
  • menu-button/menu-button-actions-active-descendant.html:
    • menu-up-arrow
    • menu-down-arrow
    • menu-character
  • toolbar/toolbar.html:
    • toolbar-tab
    • toolbar-right-arrow
    • toolbar-left-arrow
    • toolbar-home
    • toolbar-end
    • toolbar-toggle-esc
    • toolbar-toggle-enter-or-space
    • toolbar-radio-enter-or-space
    • toolbar-radio-down-arrow
    • toolbar-radio-up-arrow
    • toolbar-button-enter-or-space
    • toolbar-menubutton-enter-or-space-or-down-or-up
    • toolbar-menu-enter-or-space
    • toolbar-menu-down-arrow
    • toolbar-menu-up-arrow
    • toolbar-menu-escape
    • toolbar-spinbutton-down-arrow
    • toolbar-spinbutton-up-arrow
    • toolbar-spinbutton-page-down
    • toolbar-spinbutton-page-up
    • toolbar-checkbox-space
    • toolbar-link-enter-or-space
    • toolbar-spinbutton-role

Example pages with Keyboard or Attribute table rows that do not have data-test-ids:

  • dialog-modal/alertdialog.html
    • "Keyboard Support" table(s):
      • Tab
      • Shift + Tab
      • Escape
      • Command + S
      • Control + S
    • "Attributes" table(s):
      • alertdialog
      • aria-labelledby=IDREF
      • aria-describedby=IDREF
      • aria-modal=true
      • alert

SUMMARY:

55 example pages found.
1 example pages have no regression tests.
3 example pages are missing approximately 27 out of approximately 780 tests.

ERROR - missing tests:

Please write missing tests for this report to pass.

@nschonni
Copy link
Contributor Author

@mcking65 actually I'm seeing in https://github.com/w3c/aria-practices/wiki/APG-Editorial-Style-Guidelines#using-the-kbd-tag that you're recommending the combination. Is there a reason for that?

Base automatically changed from master to main March 3, 2021 18:13
@ZoeBijl
Copy link
Contributor

ZoeBijl commented Feb 14, 2022

@nschonni I assume it’s because the keys have to be pressed together?

@nschonni
Copy link
Contributor Author

The only real edge case I can see, where this approch is better is:
ctrl + +

vs.

ctrl + +

@ZoeBijl
Copy link
Contributor

ZoeBijl commented Feb 17, 2022

And maybe Ctrl + - then? 😂

@mcking65
Copy link
Contributor

replaced by #3093

@mcking65 mcking65 closed this Aug 11, 2024
@nschonni nschonni deleted the kbd-cords branch August 11, 2024 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants