Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: T6738: add build_type field to version data instead of the very limited and unused lts_build (backport #773) #775

Merged
merged 1 commit into from
Sep 30, 2024
Merged

build: T6738: add build_type field to version data instead of the very limited and unused lts_build (backport #773) #775

merged 1 commit into from
Sep 30, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Sep 30, 2024

Change Summary

Remove lts_build and add build_type that can have potentially abitrary values (in practice it will be development/stream/lts.).

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe): internal change.

Component(s) name

Build scripts.

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
This is an automatic backport of pull request #773 done by [Mergify](https://mergify.com).

@dmbaturin @mergify
build: T6738: add build_type field to version data
3f6959d 
instead of the very limited and unused lts_build

(cherry picked from commit e41d2f1)
@mergify mergify bot requested a review from a team as a code owner September 30, 2024 15:11
@mergify mergify bot mentioned this pull request Sep 30, 2024
Merged
11 tasks
@github-actions GitHub Actions
Copy link

👍
No issues in PR Title / Commit Title

@c-po c-po merged commit 5853612 into circinus Sep 30, 2024
7 checks passed
@sever-sever sever-sever deleted the mergify/bp/circinus/pr-773 branch October 17, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c-po c-po c-po approved these changes

@dmbaturin dmbaturin dmbaturin approved these changes

@sarthurdev sarthurdev Awaiting requested review from sarthurdev sarthurdev is a code owner automatically assigned from vyos/reviewers

@zdc zdc Awaiting requested review from zdc zdc is a code owner automatically assigned from vyos/reviewers

@jestabro jestabro Awaiting requested review from jestabro jestabro is a code owner automatically assigned from vyos/reviewers

@sever-sever sever-sever Awaiting requested review from sever-sever sever-sever is a code owner automatically assigned from vyos/reviewers

@nicolas-fort nicolas-fort Awaiting requested review from nicolas-fort nicolas-fort is a code owner automatically assigned from vyos/reviewers

Assignees
No one assigned
Labels
circinus
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmbaturin @c-po