-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
T861: sign all Kernel modules with an ephemeral key #772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the VyOS Linux Kernel will be compiled with CONFIG_MODULE_SIG_FORCE all driver modules need to be cryptographically signed. This happens during build of the Kernel and it's 3rd party modules. Stripping the objects would remove said signature and the system will be unable to boot b/c of CONFIG_MODULE_SIG_FORCE.
👍 |
c-po
force-pushed
the
kernel-ephemeral-keys
branch
from
September 23, 2024 19:35
2a9169c
to
3bdbad7
Compare
c-po
requested review from
dmbaturin,
sarthurdev,
zdc,
jestabro,
sever-sever and
fett0
September 23, 2024 19:43
dmbaturin
approved these changes
Sep 24, 2024
sarthurdev
approved these changes
Sep 24, 2024
Could you update scripts in the scrips/package-build dir? |
Will do |
The shim review board (which is the secure boot base loader) recommends using ephemeral keys when signing the Linux Kernel. This commit enables the Kernel build system to generate a one-time ephemeral key that is used to: * sign all build-in Kernel modules * sign all other out-of-tree Kernel modules The key lives in /tmp and is destroyed after the build container exits and is named: "VyOS build time autogenerated kernel key". In addition the Kernel now uses CONFIG_MODULE_SIG_FORCE. This now makes it unable to load any Kernel Module to the image that is NOT signed by the ephemeral key.
c-po
force-pushed
the
kernel-ephemeral-keys
branch
from
September 25, 2024 18:24
3bdbad7
to
d235b31
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
The shim review board (which is the secure boot base loader) recommends using ephemeral keys when signing the Linux Kernel. This commit enables the Kernel build system to generate a one-time ephemeral key that is used to:
The key lives in
/tmp
and is destroyed after the build container exits and is named:VyOS build time autogenerated kernel key
.In addition the Kernel now uses
CONFIG_MODULE_SIG_FORCE
. This makes it unable to load any Kernel Module to the image that is NOT signed by the ephemeral key.During system boot one will now see:
Types of changes
Related Task(s)
Related PR(s)
Component(s) name
Kernel / Boot
How to test
Checklist: