Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T973: add build script for node_exporter package #757

Closed
wants to merge 2 commits into from

Conversation

rebortg
Copy link
Member

@rebortg rebortg commented Sep 11, 2024

Change Summary

Add build script for latest node_exporter version.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

https://vyos.dev/T973

Component(s) name

service monitoring node-exporter

Proposed changes

How to test

after install the binary is in /usr/sbin/node_exporter

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

Copy link

github-actions bot commented Sep 11, 2024


Commit title 'Delete packages/node_exporter/Jenkinsfile' does not match the required format!. Valid title example: T99999: make IPsec secure

@sever-sever
Copy link
Member

sever-sever commented Sep 12, 2024

I do not see the Jenkinsfile with scmCommit, scmUrl, buildCmd
Can we use the scmCommit the same way as for other packages?
Example https://github.com/vyos/vyos-build/blob/55c17f9283f32d9e2d1e562ab2e413ce55d108d3/packages/ddclient/Jenkinsfile

step 2
After the merge, I will rewrite the script to build the packages without Jenkins, it uses common build.py mostly for all packages (without Jenkins)
for example

@rebortg
Copy link
Member Author

rebortg commented Sep 15, 2024

sorry i missed your reply....

I do not see the Jenkinsfile with scmCommit, scmUrl, buildCmd Can we use the scmCommit the same way as for other packages? Example https://github.com/vyos/vyos-build/blob/55c17f9283f32d9e2d1e562ab2e413ce55d108d3/packages/ddclient/Jenkinsfile

the problem i see is, i created the build script to pull always the latest version and i don't know how to implement this behaivor in the Jenkinsfile.

If this is not possible or not wanted i have to change the build.py to pull a fixed version.

@sever-sever
Copy link
Member

sever-sever commented Sep 16, 2024

sorry i missed your reply....

I do not see the Jenkinsfile with scmCommit, scmUrl, buildCmd Can we use the scmCommit the same way as for other packages? Example https://github.com/vyos/vyos-build/blob/55c17f9283f32d9e2d1e562ab2e413ce55d108d3/packages/ddclient/Jenkinsfile

the problem i see is, i created the build script to pull always the latest version and i don't know how to implement this behaivor in the Jenkinsfile.

If this is not possible or not wanted i have to change the build.py to pull a fixed version.

You can copy this Jenkinsfile and use master or some commit id for example

'scmCommit': 'master',

Then just call buildCmd
'buildCmd': 'cd ..; ./build-openvpn-otp.sh'],

These commands are required to build packages by Jenkins

name
scmCommit
scmUrl
buildCmd

@rebortg rebortg force-pushed the node_exporter branch 2 times, most recently from ece653f to 27337d9 Compare September 17, 2024 19:38
@rebortg
Copy link
Member Author

rebortg commented Sep 17, 2024

i created the Jenkinsfile to the best of my belief. I hope this is fine now, if not let me know.

packages/node_exporter/build.py Outdated Show resolved Hide resolved
@sever-sever
Copy link
Member

@rebortg Check please this PR #785

@sever-sever
Copy link
Member

Jenkins build is a deprecated
replacement #785

@sever-sever sever-sever closed this Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants