Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T6231: update OFED version and fix build script #744

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

sempervictus
Copy link

Change Summary

Push OFED to 24.07-0.6.1.0
Replace bash syntax for conditional check with sh syntax in OFED build script.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe): OFED driver update

Related Task(s)

Component(s) name

OFED

Proposed changes

How to test

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

Copy link

github-actions bot commented Aug 24, 2024

👍
No issues in PR Title / Commit Title

@sempervictus
Copy link
Author

Given the rate at which OFED updates and them having a stable/tip cadence like VyOS does, how do we want to handle the version tempos?
My $0.02 there would be to keep rolling on the tip OFED to provide as many offload functions/new features as feasible while packaging the version-appropriate LTS into a stable release

@sempervictus sempervictus changed the title T6231: OFED: update version and fix build script T6231: update OFED version and fix build script Aug 24, 2024
Push OFED to 24.07-0.6.1.0
Replace bash syntax for conditional check with sh syntax in OFED
build script.
@c-po
Copy link
Member

c-po commented Aug 24, 2024

Given the rate at which OFED updates and them having a stable/tip cadence like VyOS does, how do we want to handle the version tempos? My $0.02 there would be to keep rolling on the tip OFED to provide as many offload functions/new features as feasible while packaging the version-appropriate LTS into a stable release

We can test latest versions in rolling and once that's backported to LTS and known good we can select "good" versions

@c-po c-po enabled auto-merge August 24, 2024 16:43
@sempervictus
Copy link
Author

How should we handle that re phabricator? I can keep appending to this T# or I guess create new ones each time which seems a bit overkill for the churn rate.

@c-po c-po merged commit bca5611 into vyos:current Aug 26, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants