Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddclient: T5797: switch to Debian SALSA repository #694

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

c-po
Copy link
Member

@c-po c-po commented Jul 12, 2024

Change Summary

Commit 368b89e ("ddclient: T5797: Upgrade to ddclient 3.11.2") bumped the ddclient version by using the build system from Debian SALSA repo and the upstream ddclient source code.

Debian now provides the same version from the SALSA repos.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Component(s) name

ddclient

How to test

Smoketests

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@c-po c-po requested a review from a team as a code owner July 12, 2024 18:55
@c-po
Copy link
Member Author

c-po commented Jul 12, 2024

@Mergifyio backport circinus sagitta

Copy link

github-actions bot commented Jul 12, 2024

👍
No issues in PR Title / Commit Title

Copy link

mergify bot commented Jul 12, 2024

backport circinus sagitta

✅ Backports have been created

@indrajitr
Copy link
Contributor

Thanks @c-po! We can now remove build.sh as well.

Commit 368b89e ("ddclient: T5797: Upgrade to ddclient 3.11.2") bumped the
ddclient version by using the build system from Debian SALSA repo and the
upstream ddclient source code.

Debian now provides the same version from the SALSA repos.
@sever-sever sever-sever merged commit 824ffc8 into vyos:current Jul 12, 2024
8 of 9 checks passed
@marekm72
Copy link

https://vyos.dev/T5797 seems completely unrelated to ddclient - what is the correct task?

@indrajitr
Copy link
Contributor

That should have been https://vyos.dev/T5792. I had a typo in the previous PR, my apologies.

c-po added a commit that referenced this pull request Jul 13, 2024
ddclient: T5797: switch to Debian SALSA repository (backport #694)
c-po added a commit that referenced this pull request Jul 15, 2024
ddclient: T5797: switch to Debian SALSA repository (backport #694)
@c-po c-po deleted the ddclient-build branch July 22, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants