Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

container: T5867: pin specific podman version #690

Merged
merged 1 commit into from
Jul 8, 2024
Merged

container: T5867: pin specific podman version #690

merged 1 commit into from
Jul 8, 2024

Conversation

c-po
Copy link
Member

@c-po c-po commented Jul 8, 2024

Change Summary

As of Debian version 4.9.5+ds1-1 podman increased the dependency on libc6 and libgpgme11t64.

  podman : Depends: libc6 (>= 2.38) but 2.36-9+deb12u7 is to be installed
           Depends: libgpgme11t64 (>= 1.4.1) but it is not going to be installed

Pin the version to a prior one that requires the old libc.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe): Package Downgrade

Related Task(s)

Component(s) name

podman

Proposed changes

How to test

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@c-po
container: T5867: pin specific podman version
0094dc2 
As of Debian version 4.9.5+ds1-1 podman increased the dependency on
libc6 and libgpgme11t64.

  podman : Depends: libc6 (>= 2.38) but 2.36-9+deb12u7 is to be installed
           Depends: libgpgme11t64 (>= 1.4.1) but it is not going to be installed

Pin the version to a prior one that requires the old libc.
@c-po c-po requested a review from a team as a code owner July 8, 2024 08:36
@c-po
Copy link
Member Author

c-po commented Jul 8, 2024

@Mergifyio backport circinus sagitta

@c-po c-po enabled auto-merge July 8, 2024 08:36
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 8, 2024

👍
No issues in PR Title / Commit Title

@mergify Mergify
Copy link

mergify bot commented Jul 8, 2024 •
edited
Loading

backport circinus sagitta

✅ Backports have been created

dmbaturin
dmbaturin approved these changes Jul 8, 2024
View reviewed changes
Copy link
Member

@dmbaturin dmbaturin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose we'll need to get this in as an immediate fix, but I wonder about the future.

If all newer versions will require newer glibc than we have in Bookworm, how do we keep it updated? Should we start building it ourselves?

dmbaturin
dmbaturin approved these changes Jul 8, 2024
View reviewed changes
Copy link
Member

@dmbaturin dmbaturin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for now to fix the build error.

@c-po c-po merged commit 16753c9 into vyos:current Jul 8, 2024
8 of 9 checks passed
This was referenced Jul 8, 2024
Merged
Merged
dmbaturin added a commit that referenced this pull request Jul 9, 2024
@dmbaturin
Merge pull request #691 from vyos/mergify/bp/circinus/pr-690
777bb40 
container: T5867: pin specific podman version (backport #690)
sever-sever added a commit that referenced this pull request Jul 9, 2024
@sever-sever
Merge pull request #692 from vyos/mergify/bp/sagitta/pr-690
f4512d7 
container: T5867: pin specific podman version (backport #690)
@c-po c-po deleted the podman branch July 22, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jestabro jestabro jestabro approved these changes

@dmbaturin dmbaturin dmbaturin approved these changes

@sarthurdev sarthurdev Awaiting requested review from sarthurdev sarthurdev is a code owner automatically assigned from vyos/reviewers

@zdc zdc Awaiting requested review from zdc zdc is a code owner automatically assigned from vyos/reviewers

@sever-sever sever-sever Awaiting requested review from sever-sever sever-sever is a code owner automatically assigned from vyos/reviewers

@nicolas-fort nicolas-fort Awaiting requested review from nicolas-fort nicolas-fort is a code owner automatically assigned from vyos/reviewers

Assignees

@c-po c-po

Labels
backport current
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@c-po @dmbaturin @jestabro