Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: T6446: include support URL in the version data file (backport #649) #650

Merged
merged 1 commit into from
Jun 5, 2024
Merged

build: T6446: include support URL in the version data file (backport #649) #650

merged 1 commit into from
Jun 5, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Jun 5, 2024

Change Summary

Support URL is already present in defaults.toml but not included in version.json, this PR fixes that omission.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Component(s) name

Build scripts.

Proposed changes

How to test

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
This is an automatic backport of pull request #649 done by [Mergify](https://mergify.com).

@mergify mergify bot requested a review from a team as a code owner June 5, 2024 15:45
@mergify mergify bot requested review from dmbaturin, sarthurdev, zdc, jestabro, sever-sever and c-po and removed request for a team June 5, 2024 15:45
@mergify mergify bot mentioned this pull request Jun 5, 2024
Merged
11 tasks
@github-actions github-actions bot added the sagitta VyOS 1.4 LTS label Jun 5, 2024
@c-po c-po merged commit 258b865 into sagitta Jun 5, 2024
6 checks passed
@mergify mergify bot deleted the mergify/bp/sagitta/pr-649 branch June 5, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sever-sever sever-sever sever-sever approved these changes

@jestabro jestabro jestabro approved these changes

@dmbaturin dmbaturin Awaiting requested review from dmbaturin dmbaturin is a code owner automatically assigned from vyos/reviewers

@sarthurdev sarthurdev Awaiting requested review from sarthurdev sarthurdev is a code owner automatically assigned from vyos/reviewers

@zdc zdc Awaiting requested review from zdc zdc is a code owner automatically assigned from vyos/reviewers

@c-po c-po Awaiting requested review from c-po c-po is a code owner automatically assigned from vyos/reviewers

Assignees
No one assigned
Labels
sagitta VyOS 1.4 LTS
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jestabro @sever-sever @c-po @dmbaturin