Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T6812: Fix smoketest iproute2 check #4174

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Conversation

sever-sever
Copy link
Member

Change Summary

In the new iproute2 package, the link to ip was changed.

$ file /usr/sbin/ip
/usr/sbin/ip: symbolic link to ../bin/ip

Fix smoketest

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Component(s) name

smoketest, iproute2

Proposed changes

How to test

Before the fix:

vyos@r14:~$ /usr/libexec/vyos/tests/smoke/system/test_iproute2.py
test_ip_is_symlink (__main__.TestIproute2.test_ip_is_symlink) ... FAIL

======================================================================
FAIL: test_ip_is_symlink (__main__.TestIproute2.test_ip_is_symlink)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/libexec/vyos/tests/smoke/system/test_iproute2.py", line 28, in test_ip_is_symlink
    self.assertEqual(os.readlink(symlink), real_file)
AssertionError: '../bin/ip' != '/bin/ip'
- ../bin/ip
? --
+ /bin/ip


----------------------------------------------------------------------
Ran 1 test in 0.001s

FAILED (failures=1)

After the fix:

vyos@r14:~$ /usr/libexec/vyos/tests/smoke/system/test_iproute2.py
test_ip_is_symlink (__main__.TestIproute2.test_ip_is_symlink) ... ok

----------------------------------------------------------------------
Ran 1 test in 0.000s

OK
vyos@r14:~$ 

Smoketest result

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

In the new iproute2 package the link to `ip` was changed

$ file /usr/sbin/ip
/usr/sbin/ip: symbolic link to ../bin/ip

Fix smoketest
Copy link

👍
No issues in PR Title / Commit Title

Copy link

CI integration ❌ failed!

Details

CI logs

  • CLI Smoketests (no interfaces) ❌ failed
  • CLI Smoketests (interfaces only) 👍 passed
  • Config tests 👍 passed
  • RAID1 tests 👍 passed
  • TPM tests 👍 passed

@sever-sever sever-sever merged commit 9911bf3 into vyos:current Oct 25, 2024
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants