system_login: T6807: allow a trailing slash character in system login #4170
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the use of a trailing slash
("/")
at the of the user's home directory path. For example/home/test/
Change Summary
After the migration VyOS version from 1.3.x to 1.4.0, the presence of a trailing slash
("/")
at the end of the user's home directory path beaks the login process.Types of changes
Related Task(s)
Related PR(s)
Component(s) name
Proposed changes
After migrating from VyOS version 1.3.x to 1.4.0, the presence of a trailing slash
("/")
at the end of the user's home directory path breaks the login process. This issue affects both login/password authentication and SSH key-based access, making it impossible for users to log in to VyOS instances.To resolve this issue, I propose allowing the use of a trailing slash
("/")
in the home directory path. This change will ensure that users do not encounter login problems after future migrations.Examples of Allowed Paths:
/home/test/
/home/test
Examples of Disallowed Paths:
//home/test/
(contains double slashes)/home//test
(contains double slashes)home/test/
(does not start with a slash)How to test
Smoketest result
Checklist: