T6695: Machine-readable operational mode support for traceroute

[natali-rs1985]

Change Summary

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Code style update (formatting, renaming)
• Refactoring (no functional changes)
• Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
• Other (please describe):

Related Task(s)

• https://vyos.dev/T6695

Related PR(s)

Component(s) name

Proposed changes

Added new endpoint for http API /traceroute

How to test

vyos@vyos:~$ curl -k --location --request POST 'https://localhost/traceroute' --form data='{"op": "traceroute", "host": "192.0.1.1"}' --form key='foo'
{"success": true, "data": "{'report': {'mtr': {'src': 'vyos', 'dst': '192.0.1.1', 'tos': 0, 'tests': 1, 'psize': '64', 'bitpattern': '0x00'}, 'hubs': [{'count': 1, 'host': '192.168.122.1', 'Loss%': 0.0, 'Snt': 1, 'Last': 1.669, 'Avg': 1.669, 'Best': 1.669, 'Wrst': 1.669, 'StDev': 0.0}, {'count': 2, 'host': '192.168.179.2', 'Loss%': 0.0, 'Snt': 1, 'Last': 1.854, 'Avg': 1.854, 'Best': 1.854, 'Wrst': 1.854, 'StDev': 0.0}, {'count': 3, 'host': '???', 'Loss%': 100.0, 'Snt': 1, 'Last': 0.0, 'Avg': 0.0, 'Best': 0.0, 'Wrst': 0.0, 'StDev': 0.0}]}}\n", "error": null}

Smoketest result

Checklist:

• I have read the CONTRIBUTING document
• I have linked this PR to one or more Phabricator Task(s)
• I have run the components SMOKETESTS if applicable
• My commit headlines contain a valid Task id
• My change requires a change to the documentation
• I have updated the documentation accordingly

[github-actions]

❌
Commit title 'Merge branch 'current' into T6695' does not match the required format!. Valid title example: T99999: make IPsec secure

[github-actions]

✅ No issues found in unused-imports check.. Please refer the workflow run

[dmbaturin]

The logic seems fine. I have reservations about mixing formatting fixes with logic in one PR. Since formatting changes are in a separate commit, it's not an obstacle for merging, however.

[sever-sever]

I’m feeling that for op-mode diagnostic commands should be a separate endpoint.
This new endpoint will include several diagnostic commands like ping/traceroute/mtr/etc
https://infocenter.nokia.com/public/7750SR222R1A/index.jsp?topic=%2Fcom.nokia.System_Mgmt_Guide%2Fgnoi_system-ai9exj5yfo.html

But I’m not against merging it as it is at the moment

[sever-sever]

There are conflicts

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions]

Conflicts have been resolved. A maintainer will review the pull request shortly.

[github-actions]

CI integration ❌ failed!

Details

CI logs

• CLI Smoketests (no interfaces) ❌ failed
• CLI Smoketests (interfaces only) 👍 passed
• Config tests 👍 passed
• RAID1 tests 👍 passed
• TPM tests 👍 passed