Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smoketest: T5558: Extend configtest to allow checking of migration script results #2221

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

sarthurdev
Copy link
Member

Change Summary

  • Extends config smoketest to check resulting migrated CLI nodes against a file of expected nodes
  • Includes list of expected CLI nodes for tests basic-vyos and dialup-router-medium-vpn

Will add further configs/expected CLI for major migrated components (e.g. firewall/zone-policy) over time.

Note: As future migrations are added that change syntax, tests may need to be updated.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Component(s) name

smoketest

Proposed changes

How to test

Run make testc, after migration is loaded and committed, it will check config commands in the config-tests file (if present) against the effective config.

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@vyosbot vyosbot requested review from a team, dmbaturin, zdc, jestabro, sever-sever and c-po and removed request for a team September 7, 2023 19:36
smoketest/bin/vyos-configtest Outdated Show resolved Hide resolved
@c-po c-po merged commit c57a519 into vyos:current Sep 8, 2023
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants