Rewrite signature verification w/ fancy functions #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 5, 2023 14:50
This is an attempt to fix [T4915](https://phabricator.vyos.net/T4915). I have not tested this yet outside using `shellcheck`, so this definitely needs testing. But it looks cleaner and I _think_ it should work!
|
This PR is stale because it has been open 30 days with no activity. The PR will be reviewed by a maintainer and may be closed |
|
@jestabro I think this can be closed as we have the new image tools in vyos-1x? |
|
Yes, since the whole thing was rewritten, this is no longer relevant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix T4915. I have not tested this yet outside using
shellcheck, so this definitely needs testing.But it looks cleaner and I think it should work!
I'm not certain how to compile this part of VyOS to test this, and I'm hoping someone could help me do so -- a quick glance makes it look to me like this is compiled into a .deb that's then installed by https://github.com/vyos/vyos-build/blob/current/scripts/build-vyos-image ?