Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(highlighter-helper): improve collapsed lines styles #330

Merged
merged 1 commit into from
Jan 9, 2025
Merged

feat(highlighter-helper): improve collapsed lines styles #330

merged 1 commit into from
Jan 9, 2025

Conversation

Mister-Hope
Copy link
Member

@Mister-Hope Mister-Hope commented Jan 8, 2025 •
edited
Loading

Impoves hover state

  • adds a hover state when the lines are expanded
  • use highlight bg to mark the hover state. This solves the problem hover state is unrecognizable when code bg is black

@Mister-Hope Mister-Hope requested a review from pengzhanbo January 8, 2025 06:12
@netlify Netlify
Copy link

netlify bot commented Jan 8, 2025 •
edited
Loading

✅ Deploy Preview for vuepress-ecosystem ready!

Name Link
🔨 Latest commit ca845f9
🔍 Latest deploy log https://app.netlify.com/sites/vuepress-ecosystem/deploys/677e176405453d00080d51af
😎 Deploy Preview https://deploy-preview-330--vuepress-ecosystem.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12665102133

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 59.629%
Totals Coverage Status
Change from base Build 12656809313: 0.0%
Covered Lines: 1333
Relevant Lines: 2022
💛 - Coveralls

@Mister-Hope Mister-Hope changed the title feat: rebuild collapsed lines feat: improve collapsed lines styles Jan 8, 2025
@Mister-Hope Mister-Hope changed the title feat: improve collapsed lines styles feat(highlighter-helper): improve collapsed lines styles Jan 8, 2025
@Mister-Hope Mister-Hope merged commit 6c4332f into main Jan 9, 2025
38 checks passed
@Mister-Hope Mister-Hope deleted the collapsed-lines branch January 9, 2025 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pengzhanbo pengzhanbo Awaiting requested review from pengzhanbo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mister-Hope @coveralls