feat!: upgrade vite to v6 #4504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sapphi-red
commented
Jan 22, 2025
| } | ||
| return null | ||
| }, | ||
| hotUpdate(ctx) { |
There was a problem hiding this comment.
hotUpdate function is called for create/update/delete events.
Comment on lines
140
to
145
| for (const id in idToLoaderModulesMap) { | ||
| const { watch } = idToLoaderModulesMap[id]! | ||
| if (watch && isMatch(file, watch)) { | ||
| ctx.modules.push(server.moduleGraph.getModuleById(id)!) | ||
| modules.push(this.environment.moduleGraph.getModuleById(id)!) | ||
| } | ||
| } |
There was a problem hiding this comment.
The whole _importGlobMap part existed in transform hook is handled here. The affirmed / negated part is replaced with a simple isMatch because that's more aligned with the glob call.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrade Vite to v6
I added a fix for data loader hmr mentioned in #4467 (comment) as well.
Linked Issues
closes #4494
closes #4467
Additional Context
Tip
The author of this PR can publish a preview release by commenting
/publishbelow.