Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: custom directive doesn't work when custom=true #2377

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

decademoon
Copy link
Contributor

@decademoon decademoon commented Sep 30, 2024

Fix #2375.

Copy link

netlify bot commented Sep 30, 2024

Deploy Preview for vue-router canceled.

Name Link
🔨 Latest commit 0c6c6a0
🔍 Latest deploy log https://app.netlify.com/sites/vue-router/deploys/6710828045c6dd000842d86f

@posva posva changed the title fix: custom directive doesn't work when custom=true (#2375) fix: custom directive doesn't work when custom=true Oct 17, 2024
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.39%. Comparing base (14219b0) to head (0c6c6a0).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2377   +/-   ##
=======================================
  Coverage   97.39%   97.39%           
=======================================
  Files          26       26           
  Lines        6032     6036    +4     
  Branches      824      826    +2     
=======================================
+ Hits         5875     5879    +4     
  Misses        155      155           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@posva posva merged commit 0d8d997 into vuejs:main Oct 17, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Directives do not work on <RouterLink custom>
2 participants