Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(component-meta): error when signatures is undefined #4930

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Hannesrasmussen
Copy link

@Hannesrasmussen Hannesrasmussen commented Oct 18, 2024

In certain cases, signatures[0].parameters[0] returns undefined. We need to prevent this from causing an error.

packages/component-meta/lib/base.ts Outdated Show resolved Hide resolved
Copy link

pkg-pr-new bot commented Oct 18, 2024

Open in Stackblitz

vue-component-meta

pnpm add https://pkg.pr.new/vuejs/language-tools/vue-component-meta@4930

vue-component-type-helpers

pnpm add https://pkg.pr.new/vuejs/language-tools/vue-component-type-helpers@4930

@vue/language-core

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/language-core@4930

@vue/language-plugin-pug

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/language-plugin-pug@4930

@vue/language-service

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/language-service@4930

@vue/language-server

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/language-server@4930

vue-tsc

pnpm add https://pkg.pr.new/vuejs/language-tools/vue-tsc@4930

@vue/typescript-plugin

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/typescript-plugin@4930

commit: e321381

@Hannesrasmussen Hannesrasmussen changed the title fix: default to empty array if no signatures are found fix: error when signatures is undefined Oct 18, 2024
@KazariEX KazariEX changed the title fix: error when signatures is undefined fix(component-meta): error when signatures is undefined Oct 18, 2024
@KazariEX KazariEX enabled auto-merge (squash) October 18, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants