Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(templateRef): delay setting the ref value if wrapped in Suspense #12082

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

edison1105
Copy link
Member

@edison1105 edison1105 commented Sep 30, 2024

close #4930

Copy link

github-actions bot commented Sep 30, 2024

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 100 kB (+42 B) 38 kB (+5 B) 34.2 kB (+46 B)
vue.global.prod.js 159 kB (+42 B) 57.9 kB (+8 B) 51.4 kB (-1 B)

Usages

Name Size Gzip Brotli
createApp (CAPI only) 47 kB (+42 B) 18.3 kB (+12 B) 16.7 kB (+14 B)
createApp 55 kB (+42 B) 21.3 kB (+9 B) 19.4 kB (+25 B)
createSSRApp 59 kB (+42 B) 23 kB (+9 B) 20.9 kB (-2 B)
defineCustomElement 59.8 kB (+42 B) 22.9 kB (+12 B) 20.8 kB (-52 B)
overall 68.7 kB (+42 B) 26.4 kB (+8 B) 23.9 kB (-42 B)

Copy link

pkg-pr-new bot commented Sep 30, 2024

Open in Stackblitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@12082

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@12082

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@12082

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@12082

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@12082

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@12082

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@12082

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@12082

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@12082

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@12082

vue

pnpm add https://pkg.pr.new/vue@12082

commit: 754c3ba

@edison1105 edison1105 added ready to merge The PR is ready to be merged. 🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. ready for review This PR requires more reviews and removed ready to merge The PR is ready to be merged. labels Sep 30, 2024
@edison1105 edison1105 marked this pull request as draft October 1, 2024 02:07
@edison1105 edison1105 closed this Oct 21, 2024
@edison1105 edison1105 deleted the edison/fix/4930 branch October 21, 2024 07:35
@edison1105 edison1105 restored the edison/fix/4930 branch October 21, 2024 08:26
@edison1105 edison1105 reopened this Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. ready for review This PR requires more reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

template ref can not get exposed value from a top level await component
1 participant