Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: The theme color does not take effect on the login page #1420

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

KaiKaio
Copy link

@KaiKaio KaiKaio commented Mar 21, 2023

First of all, thank you for your contribution! 😄

Pull request will be merged after one of collaborators approve.
Please makes sure that these form are filled before submitting your pull request, thank you!

这个变动的性质是

  • 新特性提交
  • 日常 bug 修复
  • 文档改进
  • 组件样式改进
  • 重构
  • 代码风格优化
  • 分支合并
  • 其他改动(是关于什么的改动?)

需求背景

  1. 描述相关需求的来源。
  2. 要解决的问题。
  3. 相关的 issue 讨论链接。
    Related issue The theme color does not take effect on the login page (主题色首屏在登录页未能生效) #1419

实现方案和 API(非新功能可选)

原有 @ant-design-vue/pro-layout 的 updateTheme 在 BasicLayout 中首次调用,而 Login.vue 不在 BasicLayout 下,故未能触发主题色更新

对用户的影响和可能的风险(非新功能可选)

  1. 无影响,只是将 BasicLayout 执行的片段移动到了 App.vue 中

Changelog 描述(非新功能可选)

  1. fix: The theme color does not take effect on the login page
  2. 修复主题色首屏在登录页未能生效缺陷

请求合并前的自查清单

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • Changelog 已提供或无须提供

后续计划(非新功能可选)

如果这个提交后面还有相关的其他提交和跟进信息,可以写在这里。

@KaiKaio
Copy link
Author

KaiKaio commented Mar 21, 2023

Related issue #1419

Copy link
Author

@KaiKaio KaiKaio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BasicLayout.vue 执行的的 updateTheme() 方法提前至 App.vue 的 created 声明周期中

@JaneYork
Copy link

JaneYork commented Jan 3, 2024

BasicLayout.vue 执行的的 updateTheme() 方法提前至 App.vue 的 created 声明周期中

切换多主题,不生效,可能原因有哪些呢?
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants