-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor and test LUT functions #353
Conversation
I will be testing this over the weekend. Question @vroland
Is there now a way to also draw something in 8ppB mode, basically full monochrome, using the high level API? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All examples seem to still work after this upgrade. Would like to have the questions made before replied but does not have to be in this PR.
We can move them to discussions.
For 1: The issue was that on the esp32-s3 the line queue was used for output lines after the waveform lookup, but for v6 and below it was used for raw input data. I moved the masking so it always operates on the output lines. For 2: The idea is to have a quick visual test that things look correct with the different buffer settings. Maybe eventually we can also use it to test the actual output in the simulator. The last question: With the high level API, you can't use full monochrome because the diffing and draw functions are not implemented for it. You'd need to use the low level API :/ |
Refactors waveform lookup calculations to be more maintainable and adds tests to avoid regressions. In the process, line masking is simplified and ordering problems in 2ppB mode are fixed (this should fix #284).
8ppB now supports both PREVIOUSLY_BLACK and PREVIOUSLY_WHITE.