Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove clause unblocking, unused #620

Merged
merged 1 commit into from
Nov 3, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,6 @@ source_group(lib_sys_source_files FILES ${VAMPIRE_LIB_SYS_SOURCES})
set(VAMPIRE_KERNEL_SOURCES
Kernel/Clause.cpp
Kernel/ClauseQueue.cpp
Kernel/ColorHelper.cpp
Kernel/ELiteralSelector.cpp
Kernel/EqHelper.cpp
Kernel/FlatTerm.cpp
Expand Down
7 changes: 0 additions & 7 deletions Inferences/BinaryResolution.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -90,13 +90,6 @@ Clause* BinaryResolution::generateClause(
if(opts.showBlocked()) {
std::cout << "Blocked resolution of " << *queryCl << " and " << * resultCl << endl;
}
if(opts.colorUnblocking()) {
SaturationAlgorithm* salg = SaturationAlgorithm::tryGetInstance();
if(salg) {
ColorHelper::tryUnblock(queryCl, salg);
ColorHelper::tryUnblock(resultCl, salg);
}
}
return 0;
}

Expand Down
1 change: 0 additions & 1 deletion Inferences/Narrow.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
#include "Lib/VirtualIterator.hpp"

#include "Kernel/Clause.hpp"
#include "Kernel/ColorHelper.hpp"
#include "Kernel/EqHelper.hpp"
#include "Kernel/Inference.hpp"
#include "Kernel/Ordering.hpp"
Expand Down
1 change: 0 additions & 1 deletion Inferences/SubVarSup.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
#include "Lib/DHSet.hpp"

#include "Kernel/Clause.hpp"
#include "Kernel/ColorHelper.hpp"
#include "Kernel/EqHelper.hpp"
#include "Kernel/Inference.hpp"
#include "Kernel/Ordering.hpp"
Expand Down
6 changes: 0 additions & 6 deletions Inferences/Superposition.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -173,12 +173,6 @@ bool Superposition::checkClauseColorCompatibility(Clause* eqClause, Clause* rwCl
if(getOptions().showBlocked()) {
std::cout<<"Blocked superposition of "<<eqClause->toString()<<" into "<<rwClause->toString()<<std::endl;
}
if(getOptions().colorUnblocking()) {
SaturationAlgorithm* salg = SaturationAlgorithm::tryGetInstance();
ASS(salg);
ColorHelper::tryUnblock(rwClause, salg);
ColorHelper::tryUnblock(eqClause, salg);
}
env.statistics->inferencesSkippedDueToColors++;
return false;
}
Expand Down
231 changes: 0 additions & 231 deletions Kernel/ColorHelper.cpp

This file was deleted.

21 changes: 0 additions & 21 deletions Kernel/ColorHelper.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -18,15 +18,10 @@
#include "Forwards.hpp"

#include "Debug/Assertion.hpp"

#include "Lib/DHMap.hpp"
#include "Lib/Environment.hpp"

namespace Kernel {

using namespace Lib;
using namespace Saturation;

class ColorHelper {
public:

Expand All @@ -49,22 +44,6 @@ class ColorHelper {
static bool compatible(Color c1, Color c2) {
return combine(c1,c2)!=COLOR_INVALID;
}

static bool isTransparent(bool predicate, unsigned functor);
static bool hasColoredPredicates(Clause* c);
static Clause* skolemizeColoredConstants(Clause* c);
static Clause* skolemizeColoredTerms(Clause* c);

static void tryUnblock(Clause* c, SaturationAlgorithm* salg);

private:
typedef DHMap<Term*, Term*> TermMap;

static void ensureSkolemReplacement(Term* t, TermMap& map);
static void collectSkolemReplacements(Clause* c, TermMap& map);

static Term* applyReplacement(Term* t, TermMap& map);
static void collectColoredConstants(Clause* c, Stack<Term*>& acc);
};

}
Expand Down
1 change: 0 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,6 @@ VLS_OBJ= Lib/Sys/Multiprocessing.o

VK_OBJ= Kernel/Clause.o\
Kernel/ClauseQueue.o\
Kernel/ColorHelper.o\
Kernel/EqHelper.o\
Kernel/FlatTerm.o\
Kernel/Formula.o\
Expand Down
1 change: 0 additions & 1 deletion Parse/SMTLIB2.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
#include "Lib/NameArray.hpp"
#include "Lib/StringUtils.hpp"
#include "Kernel/Clause.hpp"
#include "Kernel/ColorHelper.hpp"
#include "Kernel/Formula.hpp"
#include "Kernel/FormulaUnit.hpp"
#include "Kernel/Inference.hpp"
Expand Down
1 change: 0 additions & 1 deletion Saturation/SaturationAlgorithm.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
#include "Indexing/LiteralIndexingStructure.hpp"

#include "Kernel/Clause.hpp"
#include "Kernel/ColorHelper.hpp"
#include "Kernel/EqHelper.hpp"
#include "Kernel/FormulaUnit.hpp"
#include "Kernel/Inference.hpp"
Expand Down
7 changes: 0 additions & 7 deletions Shell/Options.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2371,13 +2371,6 @@ void Options::init()
//*********************** Vinter??? *******************************
//******************************************************************

_colorUnblocking = BoolOptionValue("color_unblocking","",false);
_colorUnblocking.description="";
_lookup.insert(&_colorUnblocking);
_colorUnblocking.setExperimental();
_colorUnblocking.tag(OptionTag::OTHER);


_showInterpolant = ChoiceOptionValue<InterpolantMode>("show_interpolant","",InterpolantMode::OFF,
{"new_heur",
#if VZ3
Expand Down