Configure version.cpp at build time if git repo #618
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #610 (comment), this PR makes the
version.cpp.in
transformation happen at build time rather than configure time if the Vampire source folder is from git (i.e. there is a proper.git
subdirectory), thus ensuring that the git version number invampire ‑‑version
is always updated even if one forgets to docmake ..
beforemake
.I think I have tested this comprehensively, but there might be a sequence of:
cmake ..
; and/ormake
that results in unexpected behavior. Please inform me if that's the case!
References:
cmake -P
solution.add_custom_target
solution.