Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Geoff's idea to have an option stating the users "intent" for invoking Vampire (i.e., proving / disproving) #616

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

quickbeam123
Copy link
Collaborator

  1. An easy update to use intent for creating the effect of --mode casc_sat (we can now use --intent sat --mode casc instead).
  2. Update the samplers and, in particular, merge samplerFOF and samplerFNT (and delete samplerFNT).

Copy link
Contributor

@MichaelRawson MichaelRawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. This makes the options much more orthogonal: in future, does it make sense to have e.g. --mode smtcomp --intent sat?

@MichaelRawson MichaelRawson merged commit 442fb90 into master Oct 21, 2024
1 check passed
@MichaelRawson MichaelRawson deleted the martin-intent branch October 21, 2024 16:43
@quickbeam123
Copy link
Collaborator Author

In principle it sure does! Except that we are not very good with models for theories at the moment.

@easychair
Copy link
Contributor

easychair commented Oct 21, 2024 via email

@quickbeam123
Copy link
Collaborator Author

quickbeam123 commented Oct 22, 2024

Before we revert, let me just explain:

  • as of now, the intent is only used in casc mode, to pick the right schedule. The fact that it could simplify the code (casc_sat was simply a copy-paste of casc with a different schedule choice) points in the direction that intent might be a useful concept (of course, the code could have been written differently, but still)
  • in vampire mode (where it currently serves no role), we could make good use of intent to explicitly mark option-value combinations which lead to the loss of completeness: e.g. "You are trying to show SAT by finitely saturating the input, this might not be possible using sa=lrs, consider trying sa=otter instead."

Why is (say) -- mode vampire --intent sat better --mode sat ?

We don't have mode sat at the moment.

When we are looking for a model, is it still the Vampire mode? If yes, then why?

This depends on the definition of Vampire mode. To be honest, I never heard one. For me it's just the default (universal?) mode of operation which does not use strategy schedules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants