Adding OpenShift Template #1070
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1070 +/- ##
=======================================
Coverage 76.87% 76.87%
=======================================
Files 20 20
Lines 1310 1310
=======================================
Hits 1007 1007
Misses 303 303 ☔ View full report in Codecov by Sentry. |
|
can you squash the commits a bit and rebase against our master branch please? |
bschonec
force-pushed
the
templates
branch
3 times, most recently
from
acb6815
to
d01a099
Compare
|
I don't think that the root of the project is appropriate for the puppetbaord-s2i-emplate.yaml file. I appreciate any suggestions on the correct placement of the file. Also, a LGTM is appreciated for my changes to the README.md. |
rwaffen
reviewed
Apr 5, 2024
| -p PUPPETBOARD_SOURCE_REPOSITORY_REF="v5.4.0" \ | ||
| -p PUPPETBOARD_SERVICE_NAME=prod_puppetboard \ | ||
| --template=puppetboard-template | ||
| ``` |
There was a problem hiding this comment.
add an empty line here between ocde block and text pls.
| triggers: | ||
| - type: "GitHub" | ||
| github: | ||
| secret: "secret101" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have created an OpenShift template that allows very easy creation and configuration of the Puppetboard Docker image.
Neither the location nor the name of the template file is of any consequence (to me) so I'm looking to the community for guidance.
I have updated the README.me and it's a giant work in progress.
I would appreciate comments and changes as needed.
I realize that everything is still very rough but I wanted to get the Voxpupuli community engaged.