Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Namespace ensure_packages() #151

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Namespace ensure_packages() #151

wants to merge 1 commit into from

Conversation

smortex
Copy link
Member

@smortex smortex commented Apr 12, 2024

The ensure_packages() function is deprecated and we should use
stdlib::ensure_packages() instead.

alexjfisher
alexjfisher requested changes Apr 12, 2024
View reviewed changes
Copy link
Member

@alexjfisher alexjfisher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'd want to bump the dependency in metadata.json too.

@smortex
Namespace ensure_packages()
6ab68f7 
The ensure_packages() function is deprecated and we should use
stdlib::ensure_packages() instead.
@smortex
Copy link
Member Author

smortex commented Apr 12, 2024

You'd want to bump the dependency in metadata.json too.

Good catch, I fixed this in multiple places and it slept through! PR updated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheMeier TheMeier TheMeier approved these changes

@alexjfisher alexjfisher Awaiting requested review from alexjfisher

Assignees
No one assigned
Labels
backwards-incompatible
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smortex @alexjfisher @TheMeier