Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Rework network_route provider with resource_api #263

Open
wants to merge 20 commits into
base: master
Choose a base branch
from
Open

WIP: Rework network_route provider with resource_api #263

wants to merge 20 commits into from

Conversation

KeithWard
Copy link
Contributor

do not merge - for review only at this stage.

This is the rebase onto master of dhollinger's work, changing network_route to use the resource API.

Replaces #245

@KeithWard KeithWard changed the title Resource refactor WIP: Resource refactor Dec 8, 2019
@KeithWard KeithWard changed the title WIP: Resource refactor WIP: Rework network_route provider with resource_api Dec 8, 2019
@vox-pupuli-tasks
Copy link

Dear @KeithWard, thanks for the PR!

This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

1 similar comment
@vox-pupuli-tasks
Copy link

Dear @KeithWard, thanks for the PR!

This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

@vox-pupuli-tasks
Copy link

Dear @KeithWard, thanks for the PR!

This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

@vox-pupuli-tasks
Copy link

Dear @KeithWard, thanks for the PR!

This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

@KeithWard
Merge branch 'master' into resource_refactor
286f533 
Conflicts:
	lib/facter/network.rb
	lib/puppet/provider/network_route/redhat.rb
	spec/unit/facts/network_nexthop_ip_spec.rb
	spec/unit/facts/network_primary_interface_spec.rb
	spec/unit/facts/network_primary_ip_spec.rb
	spec/unit/provider/network_route/redhat_spec.rb
	spec/unit/provider/network_route/routes_spec.rb
	spec/unit/type/network_route_spec.rb
@vox-pupuli-tasks
Copy link

Dear @KeithWard, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli Github Bot. I noticed that your pull request has CI failures. Can you please have a look at the failing CI jobs?
If you need any help, you can reach out to us on our IRC channel voxpupuli on Freenode or our Slack channel voxpupuli at slack.puppet.com.
You can find my sourcecode at voxpupuli/vox-pupuli-tasks

@vox-pupuli-tasks
Copy link

Dear @KeithWard, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
merge-conflicts tests-fail
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KeithWard @dhoppe @dhollinger